Add the 'browser' condition for conditions when resolving #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Nov 12, 2024
|
This is not related to #2168. That bug is about the top-level |
NullVoxPopuli
commented
Nov 14, 2024
tests/scenarios/v2-addon-test.ts
Outdated
There was a problem hiding this comment.
a failing test!
My fix was insufficient!
… use a newer browser target that supports top-level await
NullVoxPopuli
force-pushed
the
use-the-browser-conditions
branch
from
24bc4ee
to
f3e095c
Compare
|
potentially blocked on vitejs/vite#17837 (unless I use a different dependency for testing -- which I probably should, as the problems I'm having here are vite-related, not embroider related) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better (?) alternative to:
(which I couldn't really get working for all the use cases (thanks attw & publint!))
context here with what I've explored may be important
Related issue
Outdated Optimize Deperror when consuming 'normal' (direct) npm packages with vite – deps not ending up innode_modules/.vite/deps#2168