[EMBR-4352] Run Swiftlint/Clang-format over RN iOS module #83
Conversation
facostaembrace
force-pushed
the
facosta/objective-c-linter-clang-format
branch
from
8fe6dd7
to
8e32a86
Compare
facostaembrace
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 28 28
Lines 1241 1241
Branches 99 92 -7
=======================================
Hits 975 975
Misses 266 266
|
| "publish-modules": "npx lerna run build && npx lerna publish", | ||
| "build": "npx lerna run build", | ||
| "test": "jest", | ||
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx --fix && prettier --write \"**/*.{js,jsx,ts,tsx,json}\" && yarn constraints --fix", |
There was a problem hiding this comment.
is this regular lint command still needed given the others we have now?
There was a problem hiding this comment.
I don't think so, the only difference is the json part and honestly I usually do not run this script. I can remove it if doesn't seems to be useful for you as well
There was a problem hiding this comment.
ya I think we can just remove
There was a problem hiding this comment.
this one will conflict since we fully changed it on 5.0, might be better to not update as part of this PR
There was a problem hiding this comment.
Yes, this is why I would prefer to wait until we make the releases and then after all merge this pr and run linters again
packages/core/scripts/util/ios.ts
Outdated
| export const EMBRACE_INIT_OBJECTIVEC = | ||
| "[[Embrace sharedInstance] startWithLaunchOptions:launchOptions framework:EMBAppFrameworkReactNative];"; | ||
| export const EMBRACE_INIT_OBJECTIVEC = `[[Embrace sharedInstance] startWithLaunchOptions:launchOptions | ||
| framework:EMBAppFrameworkReactNative];`; |
There was a problem hiding this comment.
I'm not sure about this change, since it's injected into the customer's app delegate I think this will end up including extra whitespace
Dependency ReviewThe following issues were found:
|
Test
UPDATE: previous issue was fixed. Unit tests work fine after tweaks on strings.
Goal
yarn lint:swift)yarn lint:clang)yarn lint:js). NOTE: the baseyarn lintcover json files, and json files are also into ios/android directories making the plugin to run into the entire project (resulting in unexpected behaviors)