Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpmunz/embr 4790 pass js stacktrace to ios #79

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

jpmunz
Copy link
Contributor

@jpmunz jpmunz commented Aug 23, 2024

This reverts my previous change and restores the JS side generating and passing down the stack trace. Will leave the bug on the Android side where this is being ignored and address in https://www.notion.so/embraceio/Pass-the-JS-Stack-trace-down-to-the-Android-SDK-in-logMessageWithSeverityAndProperties-35c819c417894554998d32333a49551f?pvs=4

For the iOS side accept the additional stacktrace parameter and set it to be the exception.stacktrace attribute on the log, will need an iOS SDK change to fully test this as the current behaviour would cause 2 stacktraces to show up on the log (the other under emb.stacktrace.ios for the native one), change on that side should avoid this when it sees that we've already included a stacktrace

@jpmunz jpmunz requested a review from a team August 23, 2024 17:02
Copy link

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (a4390d6) to head (2db4e17).
Report is 1 commits behind head on 5.0.

Files Patch % Lines
packages/core/src/utils/ErrorUtil.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              5.0      #79      +/-   ##
==========================================
- Coverage   79.18%   79.10%   -0.08%     
==========================================
  Files          29       29              
  Lines        1297     1302       +5     
  Branches      108      110       +2     
==========================================
+ Hits         1027     1030       +3     
- Misses        270      272       +2     
Files Coverage Δ
packages/core/src/index.ts 92.05% <100.00%> (+0.10%) ⬆️
packages/core/src/utils/ErrorUtil.ts 55.55% <50.00%> (-11.12%) ⬇️

@jpmunz jpmunz merged commit 763c2d5 into 5.0 Aug 26, 2024
2 of 3 checks passed
@jpmunz jpmunz deleted the jpmunz/EMBR-4790-pass-js-stacktrace-to-ios branch August 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants