Jpmunz/embr 4790 pass js stacktrace to ios #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts my previous change and restores the JS side generating and passing down the stack trace. Will leave the bug on the Android side where this is being ignored and address in https://www.notion.so/embraceio/Pass-the-JS-Stack-trace-down-to-the-Android-SDK-in-logMessageWithSeverityAndProperties-35c819c417894554998d32333a49551f?pvs=4
For the iOS side accept the additional stacktrace parameter and set it to be the
exception.stacktrace
attribute on the log, will need an iOS SDK change to fully test this as the current behaviour would cause 2 stacktraces to show up on the log (the other underemb.stacktrace.ios
for the native one), change on that side should avoid this when it sees that we've already included a stacktrace