EMBR-4636 calculate react native bundle id

[jpmunz]

On Android and previously on iOS 5.x we would take the given file path/url and compute the md5 hash of the contents and set this as react_native_bundle_id on the session. See:

• Android
• iOS
  • EMBDevice.m
  • EMBRNBundle.m
  • NSData+Embrace.m

This attempts to recreate that functionality in our RN Swift native module

[notion-workspace]

Implement setJavaScriptBundlePath

[jpmunz]

@ArielDemarco @TheMutsi this logic feels correct to me, e.g. only re-use the cache if the path is the same and the contents haven't been updated but it does deviate from the previous implementations so wanted to double-check

[ArielDemarco]

LGTM; I'd wait for @TheMutsi to see if there's nothing we're not considering

[TheMutsi]

@ArielDemarco can we move it to DispatchQueue bg? I think it could be very heavy

[jpmunz]

I think that makes sense, I moved the calls to compute ID to background queues

[ArielDemarco]

I'd inject an "own" UserDefaults to prevent any problem in the future (like somebody migrating to another suite, or things like that).
The only bad thing about injecting it (and having an instance variable with an own userDefaults) is that you'll have to implement Codable manually.
So, i'd suggest something in the middle, like providing a utility to create an "Embrace" UserDefaults, like this:

extension UserDefaults {
    static var embrace: UserDefaults {
        UserDefaults(suiteName: "EmbraceReactNative") ?? .standard
    }
}

And then you can replace store and fromStorage using that utility:

func store () {
        if let encoded = try? JSONEncoder().encode(self) {
            UserDefaults.embrace.set(encoded, forKey: LastBundleComputation.STORAGE_KEY)
        }
    }

    static func fromStorage() -> LastBundleComputation {
        if let storedData = UserDefaults.embrace.object(forKey: LastBundleComputation.STORAGE_KEY) as? Data,
           let loaded = try? JSONDecoder().decode(LastBundleComputation.self, from: storedData) {
            return loaded
        }

        return LastBundleComputation(path: "", computedAt: nil, id: "")
    }

[jpmunz]

makes sense, added

[ArielDemarco]

Probably many of this tests under the hood, are using UserDefaults. UserDefaults writes things to disk (in a .plist file).
So, to prevent any kind of flakyness, i'd remove all things persisted in UserDefaults between tests. In order to achieve this (considering you've made this change, i'd add this code:

    override func tearDownWithError() throws {
          UserDefaults.standard.removePersistentDomain(forName: "EmbraceReactNative")
    }

[jpmunz]

added

[TheMutsi]

I wonder if it's better not maintain "codepush" in a specific method, and just let the user set the javascript url if they are using codepush. @jpmunz what do you think? we can just remove this function and update the doc so we dont care if Codepush changes its name or method in the future

[jpmunz]

I think I'd keep it as is for the purposes of the iOS 6.x migration but I'd like to revisit along with calculating the bundle ID altogether to see if we can reduce code here, noted in https://www.notion.so/embraceio/Rethink-maintaining-support-for-OTA-updates-efe0b4b089ba487d9ab6678b7f7ca491?pvs=4

[jpmunz]

@ArielDemarco @facostaembrace @TheMutsi a bit of a larger change in cf514f5 to get this working if you wanted to recheck the PR

previously when the RN ios module was written in objective-c we had wrapped the code push in a #if __has_include(<CodePush/CodePush.h>) directive to only run if the host app actually had code push. The equivalent #if canImport(CodePush) for Swift didn't work as code push isn't exposed as a Swift module.

Instead I ended up adding a new objective-c CodePushHelper class which all it does is wrap the call we need to grab the codepush url in that same directive we previously had or nil otherwise, then on the swift side we call into that without any compiler directives