-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMBR-4337 update the install/uninstall scripts for iOS 6 #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #63 +/- ##
==========================================
+ Coverage 78.40% 79.39% +0.98%
==========================================
Files 28 29 +1
Lines 1218 1291 +73
Branches 96 104 +8
==========================================
+ Hits 955 1025 +70
- Misses 263 266 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheMutsi along with setup/run.ts, setup/setup.ts, setup/runUpdate.ts I also had to delete this file since it was referencing setup/setup.ts, it didn't seem to be used but let me know if was needed somewhere
001aafa
to
6745a0f
Compare
…ildWithSwazzler.gradle
return `import Foundation | ||
import EmbraceIO | ||
|
||
@objcMembers class EmbraceInitializer: NSObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArielDemarco this block shows the contents of the EmbraceInitializer.swift
file that the install script will automatically add to the app's ios project
Few different changes here:
Manual steps are documented in: https://github.com/embrace-io/embrace-docs/pull/596