Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMBR-4337 update the install/uninstall scripts for iOS 6 #63

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

jpmunz
Copy link
Contributor

@jpmunz jpmunz commented Aug 1, 2024

Few different changes here:

  • don't add the plist on install
  • add a common EmbraceInitializer.swift file, 2 cases for importing it, objective-c app delegate vs. swift app delegate
    • if it's objective-c need to add a bridging header file if there isn't one already
  • keep the plist and old import removals in the uninstall script in case it gets run on an old version

Manual steps are documented in: https://github.com/embrace-io/embrace-docs/pull/596

@jpmunz jpmunz requested review from TheMutsi and a team August 1, 2024 19:39
Copy link

@jpmunz jpmunz changed the title EMBR-4337 remove adding the Embrace plist file EMBR-4337 update the install/uninstall scripts for iOS 6 Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 40 lines in your changes missing coverage. Please review.

Project coverage is 79.39%. Comparing base (521b29e) to head (93c29dd).
Report is 6 commits behind head on 5.0.

Files Patch % Lines
packages/core/scripts/setup/ios.ts 9.09% 20 Missing ⚠️
packages/core/scripts/setup/uninstall.ts 66.66% 13 Missing ⚠️
...ackages/core/scripts/setup/patches/patch_ios_5x.ts 77.77% 4 Missing ⚠️
packages/core/scripts/util/ios.ts 96.15% 2 Missing ⚠️
packages/core/scripts/util/android.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              5.0      #63      +/-   ##
==========================================
+ Coverage   78.40%   79.39%   +0.98%     
==========================================
  Files          28       29       +1     
  Lines        1218     1291      +73     
  Branches       96      104       +8     
==========================================
+ Hits          955     1025      +70     
- Misses        263      266       +3     
Files Coverage Δ
packages/core/scripts/setup/patches/common.ts 75.00% <ø> (-8.34%) ⬇️
packages/core/scripts/setup/patches/patch.ts 85.00% <100.00%> (-1.28%) ⬇️
packages/core/scripts/util/android.ts 72.88% <50.00%> (-1.26%) ⬇️
packages/core/scripts/util/ios.ts 84.43% <96.15%> (+11.99%) ⬆️
...ackages/core/scripts/setup/patches/patch_ios_5x.ts 77.77% <77.77%> (ø)
packages/core/scripts/setup/uninstall.ts 75.93% <66.66%> (-4.07%) ⬇️
packages/core/scripts/setup/ios.ts 29.16% <9.09%> (-3.78%) ⬇️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMutsi along with setup/run.ts, setup/setup.ts, setup/runUpdate.ts I also had to delete this file since it was referencing setup/setup.ts, it didn't seem to be used but let me know if was needed somewhere

@jpmunz jpmunz force-pushed the jpmunz/EMBR-4337-updated-ios-install-script branch from 001aafa to 6745a0f Compare August 8, 2024 19:45
@jpmunz jpmunz marked this pull request as draft August 8, 2024 19:45
@jpmunz jpmunz changed the base branch from 5.0 to jpmunz/EMBR-4634-update-ios-6.3.0 August 8, 2024 19:46
Base automatically changed from jpmunz/EMBR-4634-update-ios-6.3.0 to 5.0 August 9, 2024 13:26
@jpmunz jpmunz marked this pull request as ready for review August 13, 2024 20:55
return `import Foundation
import EmbraceIO

@objcMembers class EmbraceInitializer: NSObject {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielDemarco this block shows the contents of the EmbraceInitializer.swift file that the install script will automatically add to the app's ios project

@jpmunz jpmunz merged commit 57da81b into 5.0 Aug 15, 2024
2 of 3 checks passed
@jpmunz jpmunz deleted the jpmunz/EMBR-4337-updated-ios-install-script branch August 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants