iOS 6 - addBreadcrumb - logRNAction #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2024 10:29
jpmunz
reviewed
Jul 30, 2024
…-io/react-native-sdk into ios-6-add-breadcrumb-logrnaction
TheMutsi
changed the title
jpmunz
reviewed
Aug 1, 2024
jpmunz
reviewed
Aug 6, 2024
jpmunz
reviewed
Aug 6, 2024
jpmunz
reviewed
Aug 6, 2024
Co-authored-by: Jonathan Munz <[email protected]>
Co-authored-by: Jonathan Munz <[email protected]>
Co-authored-by: Jonathan Munz <[email protected]>
jpmunz
reviewed
Aug 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #61 +/- ##
==========================================
- Coverage 78.46% 78.15% -0.31%
==========================================
Files 28 28
Lines 1221 1227 +6
Branches 99 98 -1
==========================================
+ Hits 958 959 +1
- Misses 263 268 +5
|
jpmunz
approved these changes
Aug 13, 2024
| // TODO uncomment the expect once the method is implemented | ||
| // expect(mockSetUserAsPayer).toHaveBeenCalled(); | ||
| const promiseToResolve = setUserAsPayer(); | ||
| jest.runAllTimers(); |
There was a problem hiding this comment.
jest.runAllTimers(); calls shouldn't be needed here
| const result = await promiseToResolve; | ||
|
|
||
| expect(mockSetUserAsPayer).toHaveBeenCalled(); | ||
| expect(result).toBe(false); |
There was a problem hiding this comment.
there's not much value in asserting this since it's just the value returned from the mock in this test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Refactor RN Action to use Spans
Add Breadcrumb in ios