EMBR-3962 remove react-native-test-suite app #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facostaembrace
approved these changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 79.60% 79.60%
=======================================
Files 29 29
Lines 1476 1476
Branches 281 282 +1
=======================================
Hits 1175 1175
+ Misses 301 279 -22
- Partials 0 22 +22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last dependabot security alerts are all coming from this example app: https://github.com/embrace-io/embrace-react-native-sdk/security/dependabot
With the work on integration testing the idea is to add more apps like
integration-tests/basic-test-appas well as templates to allow new ones to be spun up more easily and eventually remove the older stuff from examples/. Not quite there yet but rather than spend time addressing the alerts it seemed simpler to just remove this app a bit early in order to resolve them, if we still need it for QA for a new release we could checkout one of the recent tags (e.g.v5.0.1) to regain access to it