[EMBR-3910] IOS - Allow the Embrace RN Sdk to be configured with a custom exporter #192

facostaembrace · 2024-10-15T12:35:39Z

Goal

NOTE: To cleanup Android part, hoping to cover only IOS in this PR.

Testing

Release Notes

WHAT:

WHY:

WHO:

* ios 6.x features - Log is pending * Refactor catch * Refactor ios 6.x + deprecate methods * Remove deprecated methods * add persona methods to swift * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * fix tests * Comments + Fix * Add test * remove endAppStartup * ios-6-refactor * Add .process to addResource * Change setUserName for setUsername * Add constant froom index was making test fails. The constants were copied and pasted to the test file - TODO Check why it happened and fix it * Remove clearUserInfo --------- Co-authored-by: Damian Mussi <[email protected]> Co-authored-by: Jonathan Munz <[email protected]>

* enabling logNetworkRequest/logNetworkClientError for both android/ios * fixing emb.type * conditioning attributes / adding asserts to test cases * unskipping tests + fixing failure * statusCode back to Double * removing 'error' as parameter of logNetworkRequest method (both ios/android) * fixing jest unit tests * fixed mock

* logRNAction * addBreadcrumb * add test for duplicate span attributes * add incomplete + change record complete > stopSpa * Remove send_inmeddiate, its not longer needed * Refactor payer to add literal, payer * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/action-tracker/src/index.ts Co-authored-by: Jonathan Munz <[email protected]> * Update packages/action-tracker/src/index.ts Co-authored-by: Jonathan Munz <[email protected]> * Comments * Remove attributePromises * Fix test + add validations --------- Co-authored-by: Damian Mussi <[email protected]> Co-authored-by: Jonathan Munz <[email protected]>

* Start end view native * React Navigation * Changes * Android change + test * Change start span * Fix comment * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update embrace.test.ts * expect any RN version as long as its a string --------- Co-authored-by: Damian Mussi <[email protected]> Co-authored-by: Jonathan Munz <[email protected]>

* [EMB-4462] Implement logUnhandledJSException / logHandledError * clean up * polishing ios methods * implemented methods and unit tests * fix for methods * cleaning up * removing code related to logUnhandledJSException * updating readme.md file

…#81)

* (integration-tests): fixing script for update packages * updating basic-test-app to point to 6.3.0

…perties) + jest config (#126)

…xporter

…o-be-configured-with-a-custom-exporter

notion-workspace · 2024-10-15T12:35:58Z

Allow the Embrace RN SDK to be configured with a custom exporter

facostaembrace · 2024-10-15T12:37:23Z

integration-tests/basic-test-app/ios/Podfile.lock

@@ -1563,6 +1569,7 @@ PODS:
    - ReactCommon/turbomodule/core
    - Yoga
  - SocketRocket (0.7.0)
+  - SwiftProtobuf (1.20.2)


to confirm: why this is listed twice?

github-actions · 2024-10-15T12:37:29Z

Dependency Review

The following issues were found:

❌ 2 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 1 package(s) with unknown licenses.
⚠️ 42 packages with OpenSSF Scorecard issues.

View full job summary

jpmunz · 2024-10-15T19:31:14Z

DEVELOPING.md

@@ -25,6 +27,119 @@ are shared between multiple packages then they should be added to the Yarn const
 This is also where we define common peerDependencies and enforce a common version. These are packages such as React Native
 that our packages require but that we leave to the customer to have defined as explicit dependencies.

+## Adding new Native Modules


this has some similar information to packages/react-native-tracer-provider/DEVELOPING.md but is more comprehensive, I added a note to https://www.notion.so/embraceio/Strategy-Template-for-new-packages-that-have-native-code-10a7e3c99852800faf13cc70fe783f25?pvs=4 that after merging we can delete packages/react-native-tracer-provider/DEVELOPING.md and move any extra information from there into this file

jpmunz · 2024-10-15T19:33:50Z

DEVELOPING.md

+```
+packages/
+└── my-new-package/
+    ├── ios/                 # containing an Xcode workspace/project


were you able to get ios + android building using this structure without requiring a separate native-src/ folder to wrap the package inside a test react native app?

jpmunz · 2024-10-15T19:34:30Z

integration-tests/basic-test-app/app/(tabs)/index.tsx

@@ -84,6 +84,22 @@ const HomeScreen = () => {
          title="CRASH (not anonymous)"
        />
      </ThemedView>
+
+      <ThemedView style={styles.stepContainer}>


looks to be duplicated from above

jpmunz · 2024-10-15T19:39:49Z

packages/react-native-otlp/RNEmbraceOTLP.podspec

+  s.dependency 'React-Core'
+  s.dependency 'SwiftProtobuf', '1.20.2'
+  s.dependency 'EmbraceInternalSwiftLog', '1.4.4-internal'
+  s.dependency 'EmbraceIO', '6.4.2'


TODO update to s.dependency 'EmbraceIO', package["embrace"]["iosVersion"] once tracer provider package is merged

jpmunz · 2024-10-15T19:42:06Z

...s/RNEmbraceOTLP/InternalOpenTelemetry/OpenTelemetryProtocolCommon/common/CommonAdapter.swift

@@ -0,0 +1,104 @@
+/*


for files that were copied can you add a comment with a perma link to their locations in a github repo?

jpmunz · 2024-10-15T19:47:27Z

packages/react-native-otlp/src/index.ts

+  traceExporter?: CustomExporterConfig;
+}
+
+interface IOSConfig {


is it possible to share this with the definition from packages/core? I'd worry about this getting out of sync between the two

jpmunz · 2024-10-15T19:48:37Z

packages/react-native-otlp/src/utils.ts

@@ -0,0 +1,17 @@
+const createFalsePromise = () => {


I'm not sure if these are needed, could use Promise.reject/resolve instead: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/reject

jpmunz · 2024-10-15T19:50:02Z

packages/react-native-otlp/ios/RNEmbraceOTLP/RNEmbraceOTLP.swift

+import OpenTelemetrySdk
+import EmbraceCommonInternal
+
+class SDKConfig: NSObject {


similarly here for sharing with core, not sure how easy it would be though given it's at the swift layer

jpmunz · 2024-10-15T19:53:05Z

packages/react-native-otlp/ios/RNEmbraceOTLP/RNEmbraceOTLP.swift

+                        endpoints: endpoints,
+                        captureServices: servicesBuilder.build(),
+                        crashReporter: crashReporter,
+                        export: customExporters


overall I think this approach makes sense, I think the 2 main things to see about would be: 1) is there any way to avoid some of the duplication with the code in coreand 2) making sure we include code samples for customers to do the custom export themselves if they have their SDK startup defined in native code rather than going through the JS wrapper, similar to what we have for: https://embrace.io/docs/react-native/integration/track-navigation-screens/#disable-auto-tracking-for-native-screens

…o-be-configured-with-a-custom-exporter

facostaembrace · 2024-10-15T12:38:25Z

packages/core/ios/RNEmbrace/EmbraceManager.swift

+                        crashReporter: crashReporter,
+                        // if config is here, add it
+                        // config.exporter
+                        export: nil


to cleanup, not longer valid here (covered in new package)

facostaembrace · 2024-10-15T12:39:21Z

packages/react-native-otlp/README.md

Placeholder, to complete

TheMutsi and others added 30 commits July 29, 2024 17:24

EMBR-4343 get basic test passing (#57)

a27a2bb

EMBR-4422 native module interface for spans (#59)

74e2b92

flush spans after adding attributes or events

2c6be4a

Update iOS initialization to configure from code instead of plist (#62)

009ee6e

EMBR-4619 fix swift tests (#65)

cb392ce

EMBR-4612 use nulls for timestamps on android instead of 0 (#64)

6f353cc

EMBR-4627 fix flaky tests (#67)

1b42a9b

EMBR-4625 handle removing session properties for all lifespans (#66)

0748517

EMBR-4634 update to ios 6.3.0 (#68)

521b29e

bump package version to 5.0.0-alpha.0 for QA

38d73e8

misc cleanup to 5.0 branch (#71)

a163e0b

EMBR-4337 update the install/uninstall scripts for iOS 6 (#63)

57da81b

fix Java syntax error

97ab747

EMBR-4336 port over docs changes to readme

d88fffd

EMBR-4778 fix logging api (#76)

5f04e98

EMBR-4795 use addBreadcrumb (#80)

a4390d6

Jpmunz/embr 4790 pass js stacktrace to ios (#79)

763c2d5

EMBR-4796 string returned from getLastRunEndState needs to match enum (…

4500408

…#81)

(integration-test): local embrace script fixes (#78)

712f6e0

* (integration-tests): fixing script for update packages * updating basic-test-app to point to 6.3.0

EMBR-4804 fix android start view (#85)

d8c4c7c

EMBR-4821 fix path for bridging header (#86)

86bb2ce

EMBR-4636 calculate react native bundle id (#72)

890ed6d

[EMBR-4464] Hook Swift tests up to CI (#84)

72cc4dc

EMBR-4935 unit tests passing on 6.4.0 (#119)

5579424

[EMBR-4462] Implement Log Unhandled JS Exceptions (#88)

3e99b07

facostaembrace and others added 22 commits September 13, 2024 11:53

(fix): Removing Embrace-Info.plist reference + tweak for ts type (Pro…

37dfea8

…perties) + jest config (#126)

updating to ios 6.4.0 (#127)

4bbac7f

[EMBR-3910] Allow the Embrace RN SDK to be configured with a custom e…

e10fd91

…xporter

Android package

3921968

ios WIP

1502c9b

adding ios native module/tweaks for documentation

33e9cc3

android/ios projects

fcbe1e2

ios setting

0296ce1

wip

8fe3573

wip

2c28879

progress on ios

05a21fe

reintroducing files

ecb3ae5

updating Podfile.lock

92094bc

Merge branch 'main' into facosta/EMBR-3910_Allow-the-embrace-rn-sdk-t…

a3d6f31

…o-be-configured-with-a-custom-exporter

progress

7a4937d

merge from main

8046c43

progressing on dependencies

e47721c

merging main branch into current

20f97a9

Merge branch 'main' into facosta/EMBR-3910_Allow-the-embrace-rn-sdk-t…

0324595

…o-be-configured-with-a-custom-exporter

building app

2977309

updating approach: ios to init from otlp package

1e38f9c

merge main into current

c74716e

facostaembrace commented Oct 15, 2024

View reviewed changes

jpmunz reviewed Oct 15, 2024

View reviewed changes

Merge branch 'main' into facosta/EMBR-3910_Allow-the-embrace-rn-sdk-t…

2dd3f61

…o-be-configured-with-a-custom-exporter

facostaembrace commented Oct 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EMBR-3910] IOS - Allow the Embrace RN Sdk to be configured with a custom exporter #192

[EMBR-3910] IOS - Allow the Embrace RN Sdk to be configured with a custom exporter #192

facostaembrace commented Oct 15, 2024 •

edited

Loading

notion-workspace bot commented Oct 15, 2024

facostaembrace Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

jpmunz Oct 15, 2024

facostaembrace Oct 15, 2024

facostaembrace Oct 15, 2024

[EMBR-3910] IOS - Allow the Embrace RN Sdk to be configured with a custom exporter #192

Are you sure you want to change the base?

[EMBR-3910] IOS - Allow the Embrace RN Sdk to be configured with a custom exporter #192

Conversation

facostaembrace commented Oct 15, 2024 • edited Loading

Goal

Testing

Release Notes

notion-workspace bot commented Oct 15, 2024

facostaembrace Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024 • edited Loading

Dependency Review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facostaembrace commented Oct 15, 2024 •

edited

Loading

facostaembrace Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading