EMBR-4336 updated docs for RN 5.0 release #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmunz
commented
Sep 18, 2024
README.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| This website is built using [Docusaurus](https://docusaurus.io/), a modern static documentation generator written using React Native and is published to [https://embrace.io/docs/](https://embrace.io/docs/) | |||
|
|
|||
| Contributions are welcomed, no matter how small! | |||
There was a problem hiding this comment.
@vitaliyf I'm gonna revert this commit on this branch as it conflicts with main now, looks like @davidlawrencer also updated the README so wasn't sure which should be taken
There was a problem hiding this comment.
Yea use his - I made this one to test deploys from your branch.
There was a problem hiding this comment.
@jpmunz can you clean up my typo at the end here 🙏
There was a problem hiding this comment.
@davidlawrencer I think best if you just open a separate PR for that, even if it's a small change helps keep things a bit more organized
Summary
|
facostaembrace
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening this update for the React Native 5.0 release against the new public embrace-docs repo