Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary json adapters #1529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes some JSON adapters that are no longer necessary. I checked by looking at each type with 'find usages' and confirmed that no serialization was done with the symbol. I'm also relying on test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner October 16, 2024 15:45
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (45e3175) to head (f497f6f).

Files with missing lines Patch % Lines
...droid/embracesdk/internal/payload/TapBreadcrumb.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
+ Coverage   81.82%   82.27%   +0.45%     
==========================================
  Files         484      478       -6     
  Lines       11398    11337      -61     
  Branches     1782     1779       -3     
==========================================
+ Hits         9326     9328       +2     
+ Misses       1262     1199      -63     
  Partials      810      810              
Files with missing lines Coverage Δ
...android/embracesdk/internal/payload/DomainCount.kt 100.00% <ø> (ø)
...embracesdk/internal/payload/LegacyExceptionInfo.kt 40.00% <ø> (+1.90%) ⬆️
...droid/embracesdk/internal/payload/TapBreadcrumb.kt 85.71% <0.00%> (+55.71%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants