Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual session control enablement #1408

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

migrate to new key disable_session_control

bbd1da4
Select commit
Loading
Failed to load commit list.
Draft

Fix manual session control enablement #1408

migrate to new key disable_session_control
bbd1da4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2024 in 0s

82.45% (-0.10%) compared to 3ff718b

View this Pull Request on Codecov

82.45% (-0.10%) compared to 3ff718b

Details

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (3ff718b) to head (bbd1da4).
Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
...dk/internal/config/behavior/SessionBehaviorImpl.kt 0.00% 0 Missing and 1 partial ⚠️
.../orchestrator/OrchestratorTerminationConditions.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   82.54%   82.45%   -0.10%     
==========================================
  Files         476      477       +1     
  Lines       10942    10964      +22     
  Branches     1668     1668              
==========================================
+ Hits         9032     9040       +8     
- Misses       1184     1195      +11     
- Partials      726      729       +3
Files with missing lines Coverage Δ
...al/session/orchestrator/SessionOrchestratorImpl.kt 93.10% <100.00%> (ø)
.../embracesdk/internal/config/remote/RemoteConfig.kt 100.00% <100.00%> (ø)
...esdk/internal/config/remote/SessionRemoteConfig.kt 100.00% <ø> (ø)
...dk/internal/config/behavior/SessionBehaviorImpl.kt 66.66% <0.00%> (ø)
.../orchestrator/OrchestratorTerminationConditions.kt 95.45% <85.71%> (ø)

... and 12 files with indirect coverage changes

View more details on Codecov