Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete integration samples from SDK #1287

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Aug 21, 2024

Goal

Delete unused integration verification code for 7.0. These are technically public so we won't merge this until we are ready for 7.0

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator Author

bidetofevil commented Aug 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil force-pushed the hho/delete-samples branch 3 times, most recently from bc7f6b7 to ca0f729 Compare September 12, 2024 15:39
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (6302f29) to head (4a5ab31).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
+ Coverage   81.81%   82.14%   +0.32%     
==========================================
  Files         484      479       -5     
  Lines       11398    11232     -166     
  Branches     1782     1744      -38     
==========================================
- Hits         9325     9226      -99     
+ Misses       1262     1211      -51     
+ Partials      811      795      -16     

see 2 files with indirect coverage changes

@bidetofevil bidetofevil force-pushed the hho/delete-samples branch 4 times, most recently from 7888965 to 3f8d3ce Compare September 16, 2024 03:46
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant