Don't disable SDK until the next cold start

[bidetofevil]

Goal

Don't stop the SDK when it is fully active even if the config service says to do so. Instead, just don't start it up next time.

This is to avoid any weird race conditions that can cause unpredictable behavior like partially recorded sessions or even crashes.

[bidetofevil]

• Don't disable SDK until the next cold start #1187 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[fractalwrench]

Ideally we should also have a test case that checks the SDK can start again after it's been stopped (i.e. that it's capable of fetching remote config even when disabled).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (8e9d89d) to head (f1ff1bd).
Report is 155 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
- Coverage   83.07%   83.03%   -0.05%     
==========================================
  Files         451      451              
  Lines       11246    11242       -4     
  Branches     1745     1744       -1     
==========================================
- Hits         9343     9335       -8     
- Misses       1134     1137       +3     
- Partials      769      770       +1     

Files	Coverage Δ
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt	76.74% <ø> (-0.18%)	⬇️
...embracesdk/internal/config/EmbraceConfigService.kt	90.07% <ø> (-0.23%)	⬇️

... and 2 files with indirect coverage changes

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[bidetofevil]

FYI, this will likely not be merged until we figure out the full scope of the Config Service changes to make changes applied pre-service startup and immutable after. If we decide to full do that, we may merge this as it gets us a step closer, but I won't touch this until then.

[github-actions]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

[github-actions]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.