Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for TS < v5 -- Setup CI for type-checking all test apps #473

Merged
merged 6 commits into from
May 6, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented May 4, 2024

Changes

  • use ember-source built in types (DT types are best effort, and not great for modern use as they are not compatible with ember-data (ember-data is compatible with the official types now))
  • update the base devDep version of ember-source to support ^
  • Add typescript test matrix
  • Drop support for typescript < 5
    • This is because @tsconfig/ember is only compatible with TS v5, due to having verbatimModuleSyntax specified
  • Test against all TS 5.x versions
    • NOTE: ember-concurrency@v2 is not compatible with the built-in ember-source types. It thinks ComputedProperty is generic (which was true from the DT types). So I've removed type-checking from the ember-concurrency test-app for now. In a future PR I think it makes sense to delete the ember-concurrency test-app entirely, because looking at the implementation of @waitFor we only happen to work with some ember-concurrency versions do to being compatible with thennables and generators -- we could probably test that stuff in isolation without ember-concurrency.
  • Add overrides for certain @glimmer/* packages due to: @glimmer/tracking depends on `@glimmer/validator 0.44.0, which is too old and breaks type-checking by default. glimmerjs/glimmer.js#413
    • also because older versions' types are not compatible with the latest stricter tsconfig from @tsconfig/ember

@NullVoxPopuli NullVoxPopuli changed the title Setup CI for type-checking all test apps Drop support for TS < v5 -- Setup CI for type-checking all test apps May 4, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address in a separate PR: getting linting (ci) agreeing with local config, upgrading lint configs, etc (prettier 3), etc

@NullVoxPopuli NullVoxPopuli merged commit 3e00691 into master May 6, 2024
29 checks passed
@NullVoxPopuli NullVoxPopuli deleted the type-check-all-test-apps branch May 6, 2024 17:17
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants