Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test context reusable during a test #1511

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Commits on Oct 22, 2024

  1. Make test context reusable during a test

    In v2.0.0 @ember/test-helpers refactored to use
    @ember/destroyable for teardown which also meant
    that the application context was destroyed during
    teardown, where previously it was only cleaned up
    and the application was destroyed.
    
    In our application tests we simulate a page
    refresh by calling `teardownContext`` and
    `setupContext`. The destroyable change broke this
    functionality because the context is now marked
    as destroyed.
    
    This commit effectively reverts the change to use
    @ember/destroyable and adds tests to ensure that
    the context is not destroyed so that it can be
    reset during a test.
    eliasdawson committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    32cbcee View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Fix lint error

    eliasdawson committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    867e84d View commit details
    Browse the repository at this point in the history
  2. Fix DOM test failures

    eliasdawson committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    af5f0b5 View commit details
    Browse the repository at this point in the history