Support @ember/test-waiters v4 #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandfresh
approved these changes
Dec 15, 2024
|
this should replace #9614 but iirc there should be a lockfile change here too? |
runspired
added
🎯 canary
|
I ran pnpm locally, and it did not generate one -- I suspect because y || x still satisfies y? 🤷 |
runspired
pushed a commit
that referenced
this pull request
Dec 19, 2024
mansona
pushed a commit
to mansona/data
that referenced
this pull request
Jan 21, 2025
# Conflicts: # packages/-ember-data/package.json # packages/ember/package.json # packages/legacy-compat/package.json # packages/request/package.json # pnpm-lock.yaml # tests/ember-data__adapter/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v4 is a v2 addon
Notes for the release
Widen support of
@ember/test-waitersto include v3 and v4