Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: break saveRecord up into legacy operations #8484

Merged
merged 3 commits into from
Mar 19, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Mar 19, 2023

(2/4ths of) the literal final step to complete #6166 💚

This PR:

  • saveRecord as request op

Next PRs:

  • [-] findBelongsTo as request op
  • [-] findHasMany as request op

To Go (for full RequestManager support): (not this PR)

  • [-] enforce immutability in dev
  • [-] handle error documents in cache
  • [-] handle meta documents in cache
  • [-] additional test coverage for Store.request, errors thrown during request
  • [-] additional test coverage for cache.peek / cache.put / cache.peekRequest
  • [-] update docs for RequestManager.useCache
  • [-] implement new Collection mode to properly reflect ResourceDocument
  • [-] ensure single-resource-document requests are notified when data changes
  • [-] determine Cache "mutability" of CollectionResourceDocument
  • [-] add tests for enhancing context.request in RequestManager before calling next

Other Notes:

  • clarify intended Error handling mechanisms/propagation
  • update RFC for RequestManager.useCache
  • update RFC for lifetimes.isSoftExpired/isHardExpired
  • update RFC for rename data => content

@runspired runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature 5.0 Roadmap labels Mar 19, 2023
@runspired runspired merged commit 7178daf into main Mar 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/legacy-save-record-op branch March 19, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 Roadmap 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant