Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATION] deprecate belongsToReference.push accepting a model #6839

Merged
merged 4 commits into from
Dec 10, 2019
Merged

[DEPRECATION] deprecate belongsToReference.push accepting a model #6839

merged 4 commits into from
Dec 10, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Dec 3, 2019

For #6166

runspired
runspired approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, one minor change to the import location desired.

packages/store/addon/-private/system/references/belongs-to.js Outdated Show resolved Hide resolved
@runspired runspired added 🏷️ feat This PR introduces a new feature 🏷️ deprecation 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 and removed 🏷️ feat This PR introduces a new feature labels Dec 3, 2019
runspired
runspired requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the deprecation infra has landed, let's go ahead and make this code-path droppable for folks using that. Otherwise this lgtm :)

@Gaurav0 Gaurav0 force-pushed the deprecate_belongs_to_reference_push_model branch from 9da5b2c to 68577ab Compare December 6, 2019 16:29
runspired
runspired approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small bit of cleanup but otherwise looks good!

packages/store/addon/-private/system/references/belongs-to.js Outdated Show resolved Hide resolved
@Gaurav0 Gaurav0 force-pushed the deprecate_belongs_to_reference_push_model branch from c84ae4a to 90feeae Compare December 10, 2019 18:28
@runspired runspired merged commit b05623b into emberjs:master Dec 10, 2019
@Gaurav0 Gaurav0 deleted the deprecate_belongs_to_reference_push_model branch December 10, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ deprecation 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaurav0 @runspired