Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember-Inspector Compatibility #1633

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

pete-the-pete
Copy link

@pete-the-pete pete-the-pete commented Jun 27, 2022

Adding _oldWillDestroy to the prototype

Addressing ember-inspector error when using nativeProperties.

An example of the error:

2i6k580nwyl2cogqdnfyozj0i:19088 Uncaught Error: Cannot set a non-whitelisted property _oldWillDestroy on type FOO
    at Proxy.setUnknownProperty (2i6k580nwyl2cogqdnfyozj0i:19088:63)
    at Object.set (2i6k580nwyl2cogqdnfyozj0i:19029:99)
    at e.retainObject (<anonymous>:4280:54)
    at RenderTree._serializeObject (<anonymous>:2172:19)
    at RenderTree._serializeItem (<anonymous>:2164:31)
    at <anonymous>:2145:28
    at Array.forEach (<anonymous>)
    at RenderTree._serializeDict (<anonymous>:2144:25)
    at RenderTree._serializeArgs (<anonymous>:2127:21)
    at RenderTree._serializeRenderNode (<anonymous>:2112:22)

This issue is also mentioned here: adopted-ember-addons/ember-changeset#589

I tested this manually by linking ember-m3, reinstalling, and running my app and launching ember-inspector.

@hjdivad hjdivad merged commit 4a62383 into ember-m3:master Jun 28, 2022
@hjdivad hjdivad added the bug ch:bugfix label Jun 28, 2022
@hjdivad hjdivad changed the title Adding _oldWillDestroy to the prototype Update Ember-Inspector Compatibility Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ch:bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants