Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember and deps #99

Merged
merged 10 commits into from
Apr 20, 2019

Conversation

kiwiupover
Copy link
Member

@kiwiupover kiwiupover commented Apr 19, 2019

https://fastboot-website-pr-99.herokuapp.com/

  • Ran ember-cli-update
  • Ran ember-cli-update codemods
  • Updated outdated dependencies
  • Updated the index.html css link
  • Fixed linting issues
  • Update tests to use node 10

@locks locks temporarily deployed to fastboot-website-pr-99 April 19, 2019 20:36 Inactive
This is the test that the heroku review server build correctly
@locks locks temporarily deployed to fastboot-website-pr-99 April 19, 2019 21:49 Inactive
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to change (just to fix CI on master) and then I think we could try another deploy 👍

.travis.yml Outdated
- yarn run lint:js
- yarn test
- npm run lint:js
- npm test

deploy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the deploy section (because it doesn't work) then we should be able to merge this and get the production website updated 👍

@kiwiupover
Copy link
Member Author

closes #95

@mansona mansona merged commit 3efdaf2 into ember-fastboot:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants