Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing section to addon guide #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonihmig
Copy link
Contributor

Provides some explanations on how to test addons for FastBoot compatibility, including useful addon links.

@stefanpenner
Copy link
Contributor

@kratiahuja I think we want to revisit this, as the existing ember-cli-addon tests are a tad on the slow side right?

@simonihmig
Copy link
Contributor Author

You refer to running test straight from the addon's dummy app, right? I am not so sure you can always do that:

So I think ember-cli-addon-tests based testing has still its valid use cases, though when you can do the same using the dummy app, that is certainly preferable...

@kratiahuja
Copy link
Contributor

@simonihmig I think we can run ember-cli-fastboot test atleast using the dummy addon. Other addons may need to write FastBoot tests with testing against ember canary but we need to re-work the testing strategy in general. It is extremely slow and fragile to write tests using ember-cli-addon-tests since the copy and linking on npm packages and creating app takes a long time. Morevoer yarn doesn't work as well. Agreed we need a solution for addons but we need to make ember-cli-addon-tests fast first.

@sdhull
Copy link
Contributor

sdhull commented Nov 26, 2018

I won't pretend I've tried any of these packages (yet) but here's another (newer) one that looks promising: https://github.com/embermap/ember-cli-fastboot-testing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants