-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to enable resilient mode #93
base: master
Are you sure you want to change the base?
Conversation
@ncastro-nypr I would love to know what |
@kiwiupover Absolutely! It's just a flag on the Fastboot object (See source here). If it is set to true the |
I lumped in the upgrade to fastboot 2.0.1 into my fork, but for the sake of this PR, it's not important. I can roll that back if there are concerns about upgrading. |
@ncastro-nypr thanks for this PR! From what I could tell after testing your branch out locally is that I believe the reason is because of this line in fastboot-express-middleware, which is used under the hood in fastboot-app-server worker.js. When I comment that line out locally (in node_modules 🤠) then resilient mode works as I'd expect. With that line left in-tact, I still get an error page returned from fastboot-app-server. |
Also: I think updating Fastboot to 2.0 should be done in a different PR. |
@ncastro-nypr ok one more thing, sorry. One thing that would improve this PR is if you could figure out how to spruce up the I've been banging my head against EDIT: sigh... I wasn't testing it on your branch, so of course it didn't work 🤦♂ |
This should fix issue #48.