Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case the cache wasn't working because
res.send
was never being called (thuscache.put
was never called).After changing the implementation to use
res.write
andres.end
and getting it to work, I noticed that the cache can only be used for caching text/html resources because theres.send()
call for a cache hit will overwrite the content type, regardless of what type it is storing (css, js etc). So you have to be careful to have a cache implementation that rejects a promise during thefetch
call if the content type is any besides text/html.Also, the cache middleware has to go before gzip otherwise gzip doesn't work.