-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump fastboot #102
Bump fastboot #102
Conversation
I aligned the travis test matrix to bring it in line with current fastboot node releases. Also, |
@lucacorti This looks good! Is a new release of fastboot-express-middleware required before merging this? |
@snewcomer I don't think a release of |
@kratiahuja could this be merged and new version released if possible, please? |
@@ -1,7 +1,9 @@ | |||
language: node_js | |||
node_js: | |||
- "4" | |||
- "stable" | |||
- "6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "6" |
@SergeAstapov I am very sorry for the delay. I am happy to merge this PR. cc: @locks not sure I understand your suggestion, but the diff looks fine to me. Please let me know if I am ready this incorrectly. |
Thank you @lucacorti and apologies for the delay again. I'll get a release out tonight cc @rwjblue |
@kratiahuja Great, thanks! Would be great if you could also roll a new release for |
@kratiahuja I was removing Node 6 since it's no longer a supported version, but it can be done afterwards! |
@locks apologies for that, I'll didn't realize it. I'll send in a PR for the same tomorrow. @lucacorti Sure let me look into that after releasing this. |
🎉 Yayyy! FYI #105 is ready to go that drops 6. Thank you again! |
Sorry for the delay, I have a PR for bumping fastboot-express-middleware: #109, once the tests pass for that, I'll merge and release [email protected] |
|
I have tested that bumping
fastboot
andfastboot-express-middleware
fixes the issue I'm experiencing withember-fetch
,fastboot-app-server
and[email protected]
reported here ember-fastboot/ember-cli-fastboot/issues/686.