Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fastboot #102

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Bump fastboot #102

merged 2 commits into from
Jul 12, 2019

Conversation

lucacorti
Copy link
Contributor

@lucacorti lucacorti commented May 6, 2019

I have tested that bumping fastboot and fastboot-express-middleware fixes the issue I'm experiencing with ember-fetch, fastboot-app-server and [email protected] reported here ember-fastboot/ember-cli-fastboot/issues/686.

@lucacorti
Copy link
Contributor Author

I aligned the travis test matrix to bring it in line with current fastboot node releases. Also, fastboot-express-middleware needs a release with bumped fastboot I think.

@snewcomer
Copy link

@lucacorti This looks good! Is a new release of fastboot-express-middleware required before merging this?

@lucacorti
Copy link
Contributor Author

@snewcomer I don't think a release of fastboot-express-middleware is strictly needed, this is sufficient, but would be nice to get rid of the fastboot 1.x dependecy.

@SergeAstapov
Copy link

@kratiahuja could this be merged and new version released if possible, please?

@@ -1,7 +1,9 @@
language: node_js
node_js:
- "4"
- "stable"
- "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "6"

@kratiahuja
Copy link
Contributor

@SergeAstapov I am very sorry for the delay. I am happy to merge this PR. cc: @locks not sure I understand your suggestion, but the diff looks fine to me. Please let me know if I am ready this incorrectly.

@kratiahuja kratiahuja merged commit 7670f13 into ember-fastboot:master Jul 12, 2019
@kratiahuja
Copy link
Contributor

Thank you @lucacorti and apologies for the delay again. I'll get a release out tonight cc @rwjblue

@lucacorti
Copy link
Contributor Author

lucacorti commented Jul 12, 2019

@kratiahuja Great, thanks! Would be great if you could also roll a new release for fastboot-express-middleware and bump that dependency too.

@locks
Copy link
Contributor

locks commented Jul 12, 2019

@kratiahuja I was removing Node 6 since it's no longer a supported version, but it can be done afterwards!

@kratiahuja
Copy link
Contributor

@locks apologies for that, I'll didn't realize it. I'll send in a PR for the same tomorrow.

@lucacorti Sure let me look into that after releasing this.

@snewcomer
Copy link

🎉 Yayyy! FYI #105 is ready to go that drops 6. Thank you again!

@kratiahuja
Copy link
Contributor

Sorry for the delay, I have a PR for bumping fastboot-express-middleware: #109, once the tests pass for that, I'll merge and release [email protected]

@kratiahuja
Copy link
Contributor

[email protected] is published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants