Fix ci and get working with Ember 5 #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running against Ember 4.4 our CI was failing, because ember-cli-babel incorrectly gets confused about which actual ember-source is in use. --- Without this change, the various ember-cli-babel processes were identifying that [email protected] was in use and was therefore transpiling all `@ember/***` module usage to `Ember` global usage. This is "fine" for Ember 3.26, but under 3.27+ "real" modules exist and globals rewriting is no longer needed.
Gaurav0
force-pushed
the
fix_ci
branch
4 times, most recently
from
38cf419
to
74a747e
Compare
Gaurav0
force-pushed
the
fix_ci
branch
2 times, most recently
from
7a16150
to
b786946
Compare
kiwiupover
reviewed
May 16, 2023
| @@ -16,15 +16,15 @@ describe('FastBootLocation Configuration', function () { | |||
|
|
|||
| return app | |||
| .create('fastboot-location-config', { | |||
| emberVersion: 'latest', | |||
| emberDataVersion: 'latest', | |||
| emberVersion: '~3.28.12', | |||
There was a problem hiding this comment.
@Gaurav0, thanks heaps for doing this.
Why fix the version to 3.?
There was a problem hiding this comment.
It matches the default version of the ember-cli-fastboot addon being used in the test.
In a followup PR, we should probably update all the defaults to 4.12. Right now, just want to get things working again.
kiwiupover
approved these changes
May 16, 2023
|
Nice work @Gaurav0 ! How can we help with this? I'm happy to do some testing with existing apps. |
|
I'm closing this for now. I've looked into it and it seems like the fix is in the wrong place. Also the PR is too big to realistically review properly. For anyone following this work I'm taking back up the mantle of fixing ember-cli-fastboot this week so don't worry about this getting lost 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #898 , #907, and #915
fastboot-shoebox-test was broken by #905
Only one test is failing, and it is due to this bug: emberjs/ember.js#20377
Update: the test is "Fixed", but only because the current release is now Ember 5.0