Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the script tag after-render #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the script tag after-render #48

wants to merge 2 commits into from

Commits on Aug 11, 2017

  1. Add the script tag after-render

    @stefanpenner @rwjblue
    stefanpenner authored and rwjblue committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    234caeb View commit details
    Browse the repository at this point in the history

  2. Fixup test assertions. 

    We cannot simply return the promise in the failure scenarios (since
returning a rejected promise will fail the test).  I have added
back a small assertion confirming the rejections in cases we _know_
should reject.

The CSS load failure scenario is a bit annoying/odd because we cannot
guarantee that we fail properly when the asset cannot be loaded (due
to lack of browser support for `onload`/`onerror` callbacks with the
`<link>` element).
    @rwjblue
    rwjblue committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    96f90e8 View commit details
    Browse the repository at this point in the history