Fix for #142

[shadyvd]

Explicit check for not-null and not-undefined when setting the default values from the configuration.

The current code will not set defaultPrepend / defaultReplace to "false" because the check will fail. The Pr fixes #142

[ghost]

@shadyvd thank you for fixing this! Could you add a test that asserts the behavior? By adding the failing test, applying your fix should ensure it passes and make it safe for us to further improve the logic in the future.

[ghost]

NOTE: Adding safety checks is a great idea. I wonder if we can make this logic clearer using a more functional programming style:

let defaults = {};
let {pageTitle = {}} = config;
['separator', 'prepend', 'replace']
  .filter(key => {
    return key in pageTitle && pageTitle[key];
  })
  .forEach(function (key) {
    defaults[`default${capitalize(key)}`] = pageTitle[key];
  });

[shadyvd]

I'm not sure if a functional programming style makes it clearer, actually. How about if we go to ember utils, and use isPresent, instead?

Do you think

if(config.pageTitle && isPresent(config.pageTitle[key]))...

is clearer?

[ghost]

@shadyvd can you add tests that assert the conditionals introduced here? Thanks 🚀

[cah-brian-gantzler]

Given that the config is an import, how would you even write a test to use varying configs?

Shouldn't this code be done in the init of the service? Anyone that would want to extend this service would completely lose the config default code.

You could also use either of the following getOwner(this).resolveRegistration('config:environment') or getOwner(this).factoryFor('config:environment').class. they both work. Now sure if one is better than the other, but it would allow in the tests to register a config (register it before the very first access) so that you could test various configs.

If needed I can put together a PR taking this approach if you would like?

[knownasilya]

@cah-briangantzler sounds good to me.

[shadyvd]

My apologies for dropping the ball on this. I'll try and get the tests done using the approach suggested by @cah-briangantzler in the next two or three days.

[cah-brian-gantzler]

Seems I must have missed the sounds good and never did a PR either. Sorry. Currently time is a little short.

[knownasilya]

Resolved in #168