Fix title rendering with FastBoot #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the detailed write-up @CvX I'm not using FastBoot, so it would be the best to have a FastBoot test suite to make sure regressions don't show up. I appreciate the changes, and will get them out ASAP |
|
I thought I was having this problem, but actually I needed to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Version 4.0.2 (PR #117) broke title rendering in apps that are using FastBoot.
It looks like title tag is being removed after the rendering? I'm not sure what the order of the actions exactly is, but the bottom line is: FastBoot server renders the title, and then, in the browser, after rendering settles, title tag is gone.
My fix is simple: since we already require title tag to be removed from index.html (if the app uses FastBoot), then there's no need to remove that tag in run-time (during neither SSR or in browser). So instead of checking for FastBoot's environment, we can check if FastBoot is present at all.
That's only a temporary solution, ideally we would implement the idea by @mydea #117 (comment) 🚀(the mentioned change has been merged into ember-cli-head, but the new release has not been published yet).
To avoid such breakages in the future, there should be tests added for FastBoot integration and possibly a second dummy app that utilizes ember-engines. I'll try look into it (though if anyone would like to jump on it, be my guest 😅).