Use package name of AbortController polyfill in whitelisted dependencies #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn’t ember-fastboot/fastboot#200 allow us to have no changes in this repo? It’s totally possible that I’ve missed something though (I’ve only done a cursory review)... |
|
This change is required by FastBoot build system, name in ember-fastboot/fastboot#200 allows to match this dependency in whitelist and require “nested” module at the same time. |
This ensures that polyfill will be listed in `dist/package.json`'s `dependencies` at build, and then properly installed in FastBoot application server.
bobisjan
force-pushed
the
require-abortcontroller-polyfill-fix
branch
from
0421d18
to
25c7ceb
Compare
xg-wang
reviewed
Nov 21, 2018
| @@ -66,6 +66,7 @@ | |||
| "configPath": "tests/dummy/config", | |||
| "fastbootDependencies": [ | |||
| "node-fetch", | |||
| "abortcontroller-polyfill", | |||
There was a problem hiding this comment.
Yea I think this is right, should we release a patch for the fix?
xg-wang
approved these changes
Nov 21, 2018
rwjblue
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that polyfill will be listed in
dist/package.json'sdependenciesat build, and then properly installed in FastBoot application server.
closes #115, and also closes mainmatter/ember-simple-auth#1690,
but requires ember-fastboot/fastboot#200, using both whitelisted package and module path, which allows to do not wait on the PR,abortcontroller-polyfill/dist/cjs-ponyfillcan be removed later.