Skip to content

fix(plugin-annotation): mark FreeText as editing on input so blur doesn't drop changes #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanlim wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

fix(plugin-annotation): mark FreeText as editing on input so blur doesn't drop changes #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fancy-oranges-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@embedpdf/plugin-annotation': patch
---

Fix FreeText/CalloutFreeText losing typed text when edited after non-isEditing blur
5 changes: 5 additions & 0 deletions packages/plugin-annotation/src/shared/components/annotations/callout-free-text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ export function CalloutFreeText({
});
};

const handleInput = () => {
editingRef.current = true;
};

const width = rect.size.width * scale;
const height = rect.size.height * scale;
const hitStrokeWidth = Math.max(strokeWidth, MIN_HIT_AREA_SCREEN_PX / scale);
Expand Down Expand Up @@ -261,6 +265,7 @@ export function CalloutFreeText({
<span
ref={editorRef}
onBlur={handleBlur}
onInput={handleInput}
tabIndex={0}
style={{
position: 'absolute',
Expand Down
5 changes: 5 additions & 0 deletions packages/plugin-annotation/src/shared/components/annotations/free-text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ export function FreeText({
});
};

const handleInput = () => {
editingRef.current = true;
};

return (
<div
style={{
Expand All @@ -89,6 +93,7 @@ export function FreeText({
<span
ref={editorRef}
onBlur={handleBlur}
onInput={handleInput}
tabIndex={0}
style={{
color: annotation.object.fontColor,
Expand Down