Fix unsubscribe handling in embed-pdf component#676
Open
keepitterron wants to merge 1 commit into
Open
Conversation
Vue's lifecycle injection APIs must run synchronously during setup() (or synchronously inside another hook). After an await, the active-instance context is gone — hence "onBeforeUnmount is called when there is no active component instance". Register `onBeforeUnmount` synchronously in setup, tracking unsubscribe via an outer variable that the async onMounted assigns. Same cleanup behavior, just wired at the right time.
|
@keepitterron is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue's lifecycle injection APIs must run synchronously during setup() (or synchronously inside another hook). After an await, the active-instance context is gone — hence "onBeforeUnmount is called when there is no active component instance".
Register
onBeforeUnmountsynchronously in setup, tracking unsubscribe via an outer variable that the async onMounted assigns. Same cleanup behavior, just wired at the right time.