Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add gte-modernbert-base #1845

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

afalf
Copy link

@afalf afalf commented Jan 21, 2025

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding datasets checklist

Reason for dataset addition: ...

  • [x ] I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • [x ] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • [ x] intfloat/multilingual-e5-small
  • [ x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • [ x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • [x ] I have filled out the metadata object in the dataset file (find documentation on it here).
  • [x ] Run tests locally to make sure nothing is broken using make test.
  • [ x] Run the formatter to format the code using make lint.

Adding a model checklist

  • [x ] I have filled out the ModelMeta object to the extent possible
  • [ x] I have ensured that my model can be loaded using
    • [x ] mteb.get_model(model_name, revision) and
    • [x ] mteb.get_model_meta(model_name, revision)
  • [ x] I have tested the implementation works on a representative set of tasks.

mteb/models/gte_models.py Outdated Show resolved Hide resolved
@Samoed Samoed changed the title Update gte_models.py fix: add gte-modernbert-base Jan 22, 2025
framework=["Sentence Transformers", "PyTorch"],
use_instructions=False,
public_training_code=None, # couldn't find
public_training_data=None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afalf Can you share your datasets and fill for the rest of gte models too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants