Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update TaskMetadata #1076

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Conversation

MartinBernstorff
Copy link
Contributor

@MartinBernstorff MartinBernstorff commented Jul 11, 2024

@KennethEnevoldsen In case of merge-conflicts, we can just re-use the .grit script and re-apply using:

grit apply _add_stats.grit tests
grit apply _add_stats.grit mteb

Fixes #1054.

Likely discovered a bug in GritQL, report here.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Martin! Also seems like it didn't take too long.

Yea we will def. have a merge conflict with #1070.

However, it seems like we can mostly resolve that by branching from that and re-applying the change (which is great!)

Will just add @isaac-chung and @gowitheflow-1998 as reviewers here as well.

docs/adding_a_dataset.md Outdated Show resolved Hide resolved
mteb/tasks/BitextMining/kat/TbilisiCityHallBitextMining.py Outdated Show resolved Hide resolved
tests/test_retrieval_abstask.py Outdated Show resolved Hide resolved
@MartinBernstorff
Copy link
Contributor Author

This looks great, thanks Martin! Also seems like it didn't take too long.

Yea we will def. have a merge conflict with #1070.

However, it seems like we can mostly resolve that by branching from that and re-applying the change (which is great!)

Will just add @isaac-chung and @gowitheflow-1998 as reviewers here as well.

Haha, yeah, if I were proficient with GritQL, it would definitely be fast. Took me a couple of hours, but much faster next time.

Copy link
Contributor

@gowitheflow-1998 gowitheflow-1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thanks for updating these. Adding modalities and changing from text_creation to sample_creation definitely makes it easier for merging meta data from the image branch and other modalities in the future. Agree with stats -> descriptive_statistics otherwise not much to add on my end.

@MartinBernstorff
Copy link
Contributor Author

@KennethEnevoldsen I've added a few points (6). Feel free to lower the amount, and then it's ready to merge 👍

@MartinBernstorff MartinBernstorff merged commit 57c1c12 into main Jul 12, 2024
7 checks passed
@MartinBernstorff MartinBernstorff deleted the mbern_update_taskmetadata branch July 12, 2024 09:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TaskMetadata
3 participants