Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rename FrameOptions enum
FrameOptionsenum toPositionInTransactionwith clearer variant names:FirstAndLastFrame→FirstAndFinalFirstFrame→FirstThenSwitchFirstAndNextFrame→FirstWithMoreNextFrame→MiddleLastFrame→FinalLastFrameNoStop→LastBeforeSwitchoperation_frames()toassign_position_in_transaction()Rationale
Clearer names = Code is more self documenting
Remove unnecessary wrapper enums
Remove unnecessary wrapper enums (
ModeandDuty) in STM32 I2C v1 driver and use PAC types (i2c::vals::FSandi2c::vals::Duty) directly.Modeenum withi2c::vals::FSDutyenum withi2c::vals::DutyTimingsstruct to store PAC types directly.f_s(),.duty())PeriModealiasRationale
The wrapper enums served no purpose other than to convert between identical types. Using PAC types directly simplifies the code with no functional changes.
The
PeriModealias added confusing complexity because the termModedid not mean the same thing for I2C v1 and v2.Conclusion
No functional changes — purely a refactor, naming and documentation improvement.