[embassy-stm32] OSPI/HSPI/XSPI transfer fixes #4737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues:
0
instead of a more informative enum variant for describing the "indirect write" mode0xFFFF
anywayI would normally pull
0xFFFF
out into something likeconst MAX_DMA_TRANSFER_BYTES: usize = 0xFFFF
and place that in the GPDMA module forembassy-stm32
, but I'm not sure if that value holds true for all STM32 variants. If that is true, then I think the code clarity would benefit from having it defined in a const.