Skip to content

stm32/timer: Support 32-bit timers in SimplePwm waveform_up method #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

stm32/timer: Support 32-bit timers in SimplePwm waveform_up method #4717

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36d368d
stm32/timer: Support 32-bit timers in SimplePwm waveform_up method
chasingRs Sep 28, 2025
04171d9
fix: correct register access for SimplePwm 32-bit timer support
chasingRs Sep 28, 2025
944fda4
Merge branch 'embassy-rs:main' into fix/simple-pwm-32bit-timer-support
chasingRs Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions embassy-stm32/src/timer/simple_pwm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,14 +339,33 @@ impl<'d, T: GeneralInstance4Channel> SimplePwm<'d, T> {
..Default::default()
};

Transfer::new_write(
dma,
req,
duty,
self.inner.regs_1ch().ccr(channel.index()).as_ptr() as *mut u16,
dma_transfer_option,
)
.await
match self.inner.bits() {
TimerBits::Bits16 => {
Transfer::new_write(
dma,
req,
duty,
self.inner.regs_1ch().ccr(channel.index()).as_ptr() as *mut u16,
dma_transfer_option,
)
.await
}
#[cfg(not(any(stm32l0)))]
TimerBits::Bits32 => {
#[cfg(not(any(bdma, gpdma)))]
panic!("unsupported timer bits");

#[cfg(any(bdma, gpdma))]
Transfer::new_write(
dma,
req,
duty,
self.inner.regs_1ch().ccr(channel.index()).as_ptr() as *mut u32,
dma_transfer_option,
)
.await
}
};
};

// restore output compare state
Expand Down
Loading