Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FPU for RP235X Core1 #3377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Totto8492
Copy link

Fix #3353

@Dirbaio
Copy link
Member

Dirbaio commented Sep 27, 2024

We should do like cortex-m-rt for consistency: enable the FPU only when building for -eabihf targets.

(I think there are reasons to not enable the FPU if you don't need it? like lower power consumption?)

https://github.com/rust-embedded/cortex-m/blob/master/cortex-m-rt/build.rs#L69-L71
https://github.com/rust-embedded/cortex-m/blob/master/cortex-m-rt/src/lib.rs#L597

@Totto8492
Copy link
Author

Oh I see. And maybe instead, should be able to easily activate the FPU only when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HardFault when using FPU on RP2350 core1
2 participants