add navigation guard for reloading

- Ticket: SUITEDEV-29114
emartech · Oct 29, 2021 · 983365c · 983365c
1 parent 727e6c2
commit 983365c
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 1 deletion.
diff --git a/src/renderer/components/app/app.html b/src/renderer/components/app/app.html
@@ -48,7 +48,7 @@ <h1 class="e-layout__title">GAP Secret Editor</h1>
             <div class="e-grid e-grid-small">
               <div class="e-cell e-cell-small">
                 <e-tooltip content="Reload secret">
-                  <div id="reload-button" class="e-btn" @click="loadSecret()" :disabled="!loadEnabled">
+                  <div id="reload-button" class="e-btn" @click="reloadSecret()" :disabled="!loadEnabled">
                     <div class="e-btn__loading" :class="{ 'e-btn__loading-active': loading.secretLoad }">
                       <e-spinner data-size="small"></e-spinner>
                       <e-icon icon="e-refresh"></e-icon>

diff --git a/src/renderer/components/app/app.js b/src/renderer/components/app/app.js
@@ -162,6 +162,11 @@ export default {
       this.setBackups(backups);
       this.selectedBackupTime = backups.length > 0 ? backups[0].backupTime : null;
     },
+    async reloadSecret() {
+      if (!this.hasSecretChanged || await notificationDisplayer.shouldChangesBeDiscarded()) {
+        await this.loadSecret();
+      }
+    },
     async loadSecret() {
       if (!this.loadEnabled) return;
 

diff --git a/src/renderer/components/app/app.spec.js b/src/renderer/components/app/app.spec.js
@@ -484,6 +484,57 @@ describe('App', () => {
     });
   });
 
+  describe('#reloadSecret', () => {
+    it('should not load secret when user cancels a change', async () => {
+      sinon.stub(kubernetesClient, 'listContexts').resolves([]);
+      sinon.stub(kubernetesClient, 'listNamespaces').resolves([]);
+      sinon.stub(kubernetesClient, 'loadSecret').resolves({ FIELD: 'loaded-value' });
+      sinon.stub(notificationDisplayer, 'shouldChangesBeDiscarded').resolves(false);
+      const { vm } = await loadApp();
+      vm.secretNamespace = 'space';
+      vm.secretName = 'name';
+      vm.originalSecret = { FIELD: 'original-value' };
+      vm.secret = [{ key: 'FIELD', value: 'changed-value' }];
+
+      await vm.reloadSecret();
+
+      expect(vm.secret).to.eql([{ key: 'FIELD', value: 'changed-value' }]);
+    });
+
+    it('should load secret when user discards unsaved changes', async () => {
+      sinon.stub(kubernetesClient, 'listContexts').resolves([]);
+      sinon.stub(kubernetesClient, 'listNamespaces').resolves([]);
+      sinon.stub(kubernetesClient, 'loadSecret').resolves({ FIELD: 'loaded-value' });
+      sinon.stub(notificationDisplayer, 'shouldChangesBeDiscarded').resolves(true);
+      const { vm } = await loadApp();
+      vm.secretNamespace = 'space';
+      vm.secretName = 'name';
+      vm.originalSecret = { FIELD: 'original-value' };
+      vm.secret = [{ key: 'FIELD', value: 'changed-value' }];
+
+      await vm.reloadSecret();
+
+      expect(vm.secret).to.eql([{ key: 'FIELD', value: 'loaded-value' }]);
+    });
+
+    it('should load secret without confirmation when there are no changes in the secret', async () => {
+      sinon.stub(kubernetesClient, 'listContexts').resolves([]);
+      sinon.stub(kubernetesClient, 'listNamespaces').resolves([]);
+      sinon.stub(kubernetesClient, 'loadSecret').resolves({ FIELD: 'loaded-value' });
+      sinon.stub(notificationDisplayer, 'shouldChangesBeDiscarded');
+      const { vm } = await loadApp();
+      vm.secretNamespace = 'space';
+      vm.secretName = 'name';
+      vm.originalSecret = { FIELD: 'original-value' };
+      vm.secret = [{ key: 'FIELD', value: 'original-value' }];
+
+      await vm.reloadSecret();
+
+      expect(vm.secret).to.eql([{ key: 'FIELD', value: 'loaded-value' }]);
+      expect(notificationDisplayer.shouldChangesBeDiscarded).to.not.have.been.called;
+    });
+  });
+
   describe('#loadSecret', () => {
     it('should not load secret when no secret is selected', async () => {
       sinon.stub(kubernetesClient, 'listContexts').resolves([]);