Skip to content

Commit

Permalink
[HIPIFY][doc][fix] Rename -DHIPIFY_CLANG_TESTS=1 to `-DHIPIFY_CLANG…
Browse files Browse the repository at this point in the history
…_TESTS=ON`

+ Value `1` is still treated as `true` by cmake, but it is not quite correct to use it

[Reason]
+ Cmake's boolean values for options declared by `option()` function should be `OFF` or `ON`
  • Loading branch information
emankov committed Sep 17, 2023
1 parent f9cebd4 commit fd8cda0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/hipify-clang.md
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ Run `Visual Studio 17 2022`, open the generated `LLVM.sln`, build all, build pro

- ***Windows***: nothing to do: all the required headers are shipped with Windows SDK

9. Set `HIPIFY_CLANG_TESTS` option turned on: `-DHIPIFY_CLANG_TESTS=1`.
9. Set `HIPIFY_CLANG_TESTS` option turned on: `-DHIPIFY_CLANG_TESTS=ON`.

10. Build and run tests:

Expand Down Expand Up @@ -409,7 +409,7 @@ Here is an example of building `hipify-clang` with testing support on `Ubuntu 21

```bash
cmake
-DHIPIFY_CLANG_TESTS=1 \
-DHIPIFY_CLANG_TESTS=ON \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=../dist \
-DCMAKE_PREFIX_PATH=/usr/llvm/16.0.6/dist \
Expand Down Expand Up @@ -592,7 +592,7 @@ cmake
-G "Visual Studio 17 2022" \
-A x64 \
-Thost=x64 \
-DHIPIFY_CLANG_TESTS=1 \
-DHIPIFY_CLANG_TESTS=ON \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=../dist \
-DCMAKE_PREFIX_PATH=d:/LLVM/16.0.6/dist \
Expand Down

0 comments on commit fd8cda0

Please sign in to comment.