feat: add support for custom function names #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimt28
changed the title
zimt28
changed the title
zimt28
force-pushed
the
feat/fun_name
branch
from
270c7d8
to
8ea53ca
Compare
emadalam
reviewed
Dec 18, 2023
| @@ -217,6 +217,23 @@ defmodule MyApp.Env do | |||
| end | |||
| ``` | |||
|
|
|||
| ## Setting custom function names | |||
|
|
|||
| You can use the `fun` option to use a custom function name instead of the default one. | |||
There was a problem hiding this comment.
How about adding a more descriptive information in the docs.
"By default the lowercase string version of the environment variable names are used to generate the corresponding function names. However you can override this behaviour by using the fun option to use a custom function name instead of the default one."
| @@ -20,7 +20,12 @@ defmodule Mahaul do | |||
|
|
|||
| Enum.each(opts, fn {key, val} -> | |||
| str_key = Atom.to_string(key) | |||
| fn_name = str_key |> String.downcase() |> String.to_atom() | |||
| fn_name_default = str_key |> String.downcase() |> String.to_atom() | |||
There was a problem hiding this comment.
You can move this statement down in the else block to keep the function name generation inside a single block and avoid computation in unused case.
fn_name =
if Keyword.keyword?(val) && Keyword.get(val, :fun, "") |> is_atom(),
do: Keyword.get(val, :fun),
else: str_key |> String.downcase() |> String.to_atom()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11