Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff-lsp to ruff of Python #4543

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Conversation

ccqpein
Copy link
Contributor

@ccqpein ccqpein commented Sep 11, 2024

Try to update ruff-lsp to ruff

related issue: #4451

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Sep 11, 2024
@jcs090218
Copy link
Member

Should we rename the file lsp-ruff-lsp.el to lsp-ruff.el? 🤔

@ccqpein
Copy link
Contributor Author

ccqpein commented Sep 14, 2024

@jcs090218 I am ok with that. it makes sense with this PR

@jcs090218
Copy link
Member

Can you update these following links and description?

We also need to rename all the variables' prefix from lsp-ruff-lsp to lsp-ruff.

@ccqpein
Copy link
Contributor Author

ccqpein commented Sep 14, 2024

@jcs090218 Just did. Hopefully I change all of them 😄

@jcs090218
Copy link
Member

Can you update the CHANGELOG.org as well? Thank you! :D

@ccqpein
Copy link
Contributor Author

ccqpein commented Sep 14, 2024

@jcs090218 Just did.

@jcs090218
Copy link
Member

And this, https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-mode.el#L189. Almost forgot about it. 😅

@ccqpein
Copy link
Contributor Author

ccqpein commented Sep 14, 2024

@jcs090218 That's ok, you forget much less than I did 😂

@jcs090218
Copy link
Member

LGTM! Thank you for your hard work! :D

@jcs090218 jcs090218 merged commit 6447c32 into emacs-lsp:master Sep 14, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants