Optimize overlay creation by checking window visibility first #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before constructing overlay Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/improve-lsp--document-highlight-callback
branch
from
8a13535
to
f57fd3e
Compare
eval-exec
commented
Jul 28, 2024
| @@ -6260,15 +6260,15 @@ A reference is highlighted only if it is visible in a window." | |||
| (-map | |||
| (-lambda ((start-window . end-window)) | |||
| ;; Make the overlay only if the reference is visible | |||
| (let ((start-point (lsp--position-to-point start)) | |||
There was a problem hiding this comment.
I think (lsp--position-to-point start) and (lsp--position-to-point end) is a heavy job.
jcs090218
approved these changes
Jul 28, 2024
kiennq
approved these changes
Sep 23, 2024
|
I think this PR is ready to merge. 💙 |
jcs090218
approved these changes
Sep 23, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new entry to CHANGELOG.md
I updated documentation if applicable (
docsfolder)This PR refactors the
lsp--document-highlight-callbackfunction to enhance its performance. By rearranging the conditions, we now check window visibility before calculating the start and end points of overlays. This change prevents the creation of overlay points and subsequent overlays for highlights that are not visible in any window, thus reducing unnecessary computations and improving efficiency. The logic for skipping the current symbol highlighting remains intact.