Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp--find-workspaces-for workspace/executeCommand respects the target command #4494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Aug 8, 2024

  1. fix: lsp--find-workspaces-for workspace/executeCommand respects the t…

    …arget command
    
    Calling
    
        (lsp--find-workspaces-for '(:method "workspace/executeCommand"
                                    :params (:command "arbitrary-command")))
    
    would return *any* workspace that had the :executeCommandProvider capability
    registerd.
    
    This would result in a given command being forwarded for **all active
    workspaces**. Some servers (such as ruff) would raise a KeyError for unknown
    commands -- causing the minibuffer to, sometimes, show an error.
    
    This change introduces a new :check-message callback that can be used in
    lsp-method-requirements -- this callback receives the workspace and the
    message to be sent.
    
    Ths entry for workspace/executeCommand has been updated to check if the target
    workspace can execute the required command.
    kassick committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    11c9cf0 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    3120ce6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    d95123d View commit details
    Browse the repository at this point in the history