Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nixd support #4125

Closed
wants to merge 1 commit into from
Closed

Conversation

colonelpanic8
Copy link

No description provided.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Aug 5, 2023
@@ -87,6 +87,27 @@
:synchronize-sections '("nil")
:server-id 'nix-nil))

(defgroup lsp-nix-nixd nil
"LSP support for Nix, using nil."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you meant nixd here ?

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a minor comment.

@paperdigits
Copy link

Can we change that comment please and merge this? I'd love to have nixd in emacs lsp-mode

@jcs090218
Copy link
Member

Can you rebase this? Thanks!

Anyway, you might want to use #4089 as a reference. Changelog, docs/lsp-clients.json, etc.

inclyc added a commit to nix-community/nixd that referenced this pull request Oct 11, 2023
Adds a section to
[editor-setup.md](https://github.com/nix-community/nixd/blob/main/docs/editor-setup.md)
that adds guidance on making nixd work with Emacs. When
emacs-lsp/lsp-mode#4125 (or another PR that adds
nixd) is merged, this section should be changed.
@yyoncho
Copy link
Member

yyoncho commented Oct 27, 2023

Can you move this to a separate file?

@KarthikNayak
Copy link

@colonelpanic8 is this something you still want to pursue? I can take over if not. :)

@colonelpanic8
Copy link
Author

Yeah go ahead!

@KarthikNayak
Copy link

@colonelpanic8 seems like it's already done
#4288

Thanks, @peterbecich.

Could one of the mods, close this issue? @psibi ?

@psibi
Copy link
Member

psibi commented Feb 3, 2024

@KarthikNayak Can you move it to a separate file as requested by Ivan in the thread ?

@psibi
Copy link
Member

psibi commented Feb 3, 2024

Ah, I see what you mean. It was in a different PR. Closing this.

@psibi psibi closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants