lsp-erlang: Add initial support for erlang-language-platform #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports erlang-ls and erlang-language-platform.
github-actions
bot
added
documentation
client
|
The windows ci job failing looks to be unrelated to this PR. |
|
Yeah, it's unrelated. There is a bug in that snapshot, so we can just ignore it for now. |
|
TBO I would prefer having each server into separate file based on the experience with rust-analyzer and rls. Willing to move it into separate one? |
If it did split it would have to be into three, lsp-erlang, lsp-erlang-ls, lsp-erlang-elp. Otherwise existing Erlang users don't know there is a new option, and we need a place for the common elements, such as switching servers. And I am not sure if the effort warrants it at this stage. |
yyoncho
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it now still supports erlang-ls, but also erlang-language-platform.