Make it possible to configure lsp-ansible as add-on? t
#4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
May 14, 2023
jcs090218
reviewed
May 23, 2023
| @@ -234,6 +241,7 @@ Pretty print the content of PARAMS." | |||
| (lsp-package-path 'ansible-language-server)) | |||
| ,@(cl-rest lsp-ansible-language-server-command)))) | |||
| :priority 1 | |||
| :add-on? lsp-ansible-add-on? | |||
There was a problem hiding this comment.
Maybe we should just set this to t? And remove custom variable lsp-ansible-add-on?.
There was a problem hiding this comment.
I'd be ok with that. I chose to make it configurable mostly for backwards compatibility.
There was a problem hiding this comment.
Is the ansible server designed to be used with other language servers? If that's the case, we can just set it to t. If no, then the PR is ready to merge.
There was a problem hiding this comment.
@jcs090218 I force-pushed making the defcustom t by default, so that it can still be customized if necessary.
diff --git a/clients/lsp-ansible.el b/clients/lsp-ansible.el
index be2263bbe..931bf0d50 100644
--- a/clients/lsp-ansible.el
+++ b/clients/lsp-ansible.el
@@ -34,9 +34,11 @@
:link '(url-link "https://github.com/ansible/ansible-language-server")
:package-version '(lsp-mode . "8.0.1"))
-(defcustom lsp-ansible-add-on? nil
- "Make the lsp client `add-on' so that it works with other language servers.
-E.g., yamlls."
+(defcustom lsp-ansible-add-on? t
+ "Make the client `add-on' so that it works with other language servers.
+`yamlls`is a common one.
+
+Enabled by default."
:type 'boolean
:group 'lsp-ansible
:package-version '(lsp-mode . "8.0.1"))
So that it can work with yamlls.
mpereira
force-pushed
the
lsp-ansible-add-on-option
branch
from
9876a7e
to
47d79d9
Compare
|
Should be good to merge. Thanks! |
|
@jcs090218 thank you for your work on lsp-mode 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it can work with yamlls.