Change the :type of pytest-at-point debug template #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `:type` of the debug template "Python :: Run pytest (at point)" should match the "LANGUAGE-ID" argument of the function (dap-register-debug-provider), otherwise the "PROVIDE-CONFIGURATION-FN" is not called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:typeof the debug template "Python :: Run pytest (at point)" should match the "LANGUAGE-ID" argument of the function(dap-register-debug-provider), otherwise the "PROVIDE-CONFIGURATION-FN" is not called (and all tests in the current buffer are run, instead of just the test function at point).I also humbly suggest to edit the doc string of
(dap-register-debug-provider)so that it explicitly references the name of the property:typeof the plist "CONFIGURATION-SETTINGS" in(dap-register-debug-template). I'm not providing a MR for this because it's entirely possible that the problem is actually me not understanding what's going on here 🙂