Feat/get latest GitHub release #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abougouffa
force-pushed
the
feat/get-latest-github-release
branch
from
d2e84d8
to
c1f3f7e
Compare
jcs090218
approved these changes
May 3, 2023
| (dest (or path | ||
| (f-join dap-utils-extension-path "github" (concat owner "." repo))))) | ||
| (dap-utils--get-extension url dest))) | ||
|
|
||
| (defun dap-utils-get-github-extension-latest-version (owner repo) |
There was a problem hiding this comment.
Will recommend to add documentation for all functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to get the latest release from Github. The current
dap-utils-get-github-extensionrequires an explicit version number, I've changed it to be optional (backward compatible), and when theversionis set to nil, it gets the latest version.TODO: Make use of the new feature to get the latest version of extensions.