-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify logic for py. #357
base: master
Are you sure you want to change the base?
Conversation
I think |
I have never used |
If you are willing to work on that we should revisit the idea of using defstructs here. It was supposed to be an intermediate state and evolve from that solution but that never happened. |
Also, there is |
Got it. If I am going to rework on this I might make another PR. Just want to keep each PR clean. :)
No quite sure what you mean by this. 😕 Let me take some time and read through the code! |
The code in dap-python tries to build a hierarchy to find out the current test method, test class, and so on. We do the same for the headerline. It will be nice if we can reuse the logic. |
As a side note, you shouldn't end your commit headings in a period, and use the imperative mood in headings: |
This patch does the following.
space
andtab