Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic for py. #357

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Simplify logic for py. #357

wants to merge 5 commits into from

Conversation

jcs090218
Copy link
Member

This patch does the following.

  • Fixed mix use of space and tab
  • Simplify logic.

@kiennq
Copy link
Member

kiennq commented Sep 9, 2020

I think dap-python has some warning when byte compile, can you help resolving that too?

@jcs090218 jcs090218 changed the title Simplify logic. Simplify logic for py. Sep 9, 2020
@jcs090218
Copy link
Member Author

I have never used cl-defstruct operation, is that how you solve the byte compile warnings? 😕 I should probably revert it if this doesn't work! Thanks!

@yyoncho
Copy link
Member

yyoncho commented Sep 9, 2020

If you are willing to work on that we should revisit the idea of using defstructs here. It was supposed to be an intermediate state and evolve from that solution but that never happened.

@yyoncho
Copy link
Member

yyoncho commented Sep 9, 2020

Also, there is lsp--symbols->symbols-hierarchy which should be usable by dap-python as well.

@jcs090218
Copy link
Member Author

If you are willing to work on that we should revisit the idea of using defstructs here. It was supposed to be an intermediate state and evolve from that solution but that never happened.

Got it. If I am going to rework on this I might make another PR. Just want to keep each PR clean. :)

Also, there is lsp--symbols->symbols-hierarchy which should be usable by dap-python as well.

No quite sure what you mean by this. 😕 Let me take some time and read through the code!

@yyoncho
Copy link
Member

yyoncho commented Sep 9, 2020

No quite sure what you mean by this. Let me take some time and read through the code!

The code in dap-python tries to build a hierarchy to find out the current test method, test class, and so on. We do the same for the headerline. It will be nice if we can reuse the logic.

@nbfalcon
Copy link
Member

nbfalcon commented Sep 9, 2020

As a side note, you shouldn't end your commit headings in a period, and use the imperative mood in headings:
"Fixed byte compile warnings." -> "Fix byte compile warnings", ....
I found this guide to be a great resource myself: https://chris.beams.io/posts/git-commit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants