jupyter-repl-mode handle yank-excluded-properties t #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better fix might include the following. (setq-local yank-excluded-properties
(remq 'field
(or
(and (listp yank-excluded-properties)
yank-excluded-properties)
;; if the user sets `yank-excluded-properties' to t we cannot recover
;; the default list of properties, so it is reproduced here for consistency
'(category field follow-link fontified font-lock-face help-echo
intangible invisible keymap local-map mouse-face read-only yank-handler)))) |
The value of `yank-excluded-properties' can be t, in which case it is not possible to `remq' 'field, causing an error. This fix will allow the mode to start, but does not handle the fact that the 'field property is still stripped.
The previous fix changed the behavior so that field was always excluded. We now restore the default list for jupyter mode buffers so that field will make it through as expected. There is no way to get all text properties so we reproduce the list from simple.el
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
yank-excluded-properties' can be t, in which case it is not possible toremq' 'field, causing an error. This fix will allow the mode tostart, but does not handle the fact that the 'field property is still stripped.